Eu que testei

AKOPSsaopkS!

Ficou muito nice 

Luan inova demais ! õ/

Muito bom mano!

Eu só por pratica, eu decidir reescrever o seu script para métodos utilizados no TFS 1.0, o script foi testado e está 100% funcional.

Agora, para facilitar o script, eu botei o ID das vocações na ordem como elas são.

Assim:

  <vocation id="9" clientid="3" name="Epic Master Sorcerer" description="a epic master sorcerer" gaincap="10" gainhp="5" gainmana="30" gainhpticks="4" gainhpamount="10" gainmanaticks="2" gainmanaamount="10" manamultiplier="1.1" attackspeed="800" basespeed="220" soulmax="200" gainsoulticks="15" fromvoc="1">
        <formula meleeDamage="1.0" distDamage="1.0" defense="1.0" armor="1.0"/>
        <skill id="0" multiplier="1.5"/>
        <skill id="1" multiplier="2.0"/>
        <skill id="2" multiplier="2.0"/>
        <skill id="3" multiplier="2.0"/>
        <skill id="4" multiplier="2.0"/>
        <skill id="5" multiplier="1.5"/>
        <skill id="6" multiplier="1.1"/>
    </vocation>
    <vocation id="10" clientid="4" name="Epic Elder Druid" description="an epic elder druid" gaincap="10" gainhp="5" gainmana="30" gainhpticks="4" gainhpamount="10" gainmanaticks="2" gainmanaamount="10" manamultiplier="1.1" attackspeed="800" basespeed="220" soulmax="200" gainsoulticks="15" fromvoc="2">
        <formula meleeDamage="1.0" distDamage="1.0" defense="1.0" armor="1.0"/>
        <skill id="0" multiplier="1.5"/>
        <skill id="1" multiplier="1.8"/>
        <skill id="2" multiplier="1.8"/>
        <skill id="3" multiplier="1.8"/>
        <skill id="4" multiplier="1.8"/>
        <skill id="5" multiplier="1.5"/>
        <skill id="6" multiplier="1.1"/>
    </vocation>
    <vocation id="11" clientid="2" name="Epic Royal Paladin" description="a epic royal paladin" gaincap="20" gainhp="10" gainmana="15" gainhpticks="3" gainhpamount="10" gainmanaticks="3" gainmanaamount="10" manamultiplier="1.4" attackspeed="800" basespeed="220" soulmax="200" gainsoulticks="15" fromvoc="3">
        <formula meleeDamage="1.0" distDamage="1.0" defense="1.0" armor="1.0"/>
        <skill id="0" multiplier="1.2"/>
        <skill id="1" multiplier="1.2"/>
        <skill id="2" multiplier="1.2"/>
        <skill id="3" multiplier="1.2"/>
        <skill id="4" multiplier="1.1"/>
        <skill id="5" multiplier="1.1"/>
        <skill id="6" multiplier="1.1"/>
    </vocation>
	<vocation id="12" clientid="1" name="Epic Elite Knight" description="an epic elite knight" gaincap="25" gainhp="15" gainmana="5" gainhpticks="2" gainhpamount="10" gainmanaticks="4" gainmanaamount="10" manamultiplier="3.0" attackspeed="800" basespeed="220" soulmax="200" gainsoulticks="15" fromvoc="4">
        <formula meleeDamage="1.0" distDamage="1.0" defense="1.0" armor="1.0"/>
        <skill id="0" multiplier="1.1"/>
        <skill id="1" multiplier="1.1"/>
        <skill id="2" multiplier="1.1"/>
        <skill id="3" multiplier="1.1"/>
        <skill id="4" multiplier="1.4"/>
        <skill id="5" multiplier="1.1"/>
        <skill id="6" multiplier="1.1"/>
    </vocation>

Bem, eu fiz isso para facilitar o script.

 

E aqui está o script:

function onUse(cid, item, frompos, itemEx, topos)
local player = Player(cid)
local item = Item(item.uid)
local vocations = {{1, 2, 3, 4}, {5, 6, 7, 8}}
local news_vocations = {9, 10, 11, 12}

	
    if isInArray(news_vocations, player:getVocation():getId()) then
        player:sendTextMessage(MESSAGE_STATUS_CONSOLE_BLUE, "You have already upgraded your vocation.")
        return true
    end
	
    if isInArray(vocations[1] , player:getVocation():getId()) then
        player:sendTextMessage(MESSAGE_STATUS_CONSOLE_BLUE, "You must to be the first promotion to use this.")
		return true
    end


	if not isInArray(vocations[1], player:getVocation():getId()) and not isInArray(vocations[2], player:getVocation():getId()) then
		player:sendTextMessage(MESSAGE_STATUS_CONSOLE_BLUE, "Your vocation is invalid.")
		return true
	end

	
    if isInArray(vocations[2], player:getVocation():getId()) then
        player:setVocation(Vocation(player:getVocation():getId()+4))
		player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "Congratulation, you have been promoted!")
		local pos = player:getPosition()
		pos:sendMagicEffect(CONST_ME_MAGIC_GREEN)
        item:remove(1)
    end
    return true
end

Bem, tanto o seu quanto o meu vão funcionar, porém se usarem o meu, terão que usar a ordem de vocações XML que eu adicionei.

Obrigado Jamison ... eu nem tinha percebido que as vocações estavam foram de ordem ... já arrumei no tópico!

Agora que você botou as vocações na ordem, atualizar o seu script, assim:

function onUse(cid, item, frompos, itemEx, topos)
    local vocs = {9,10,11,12}
    if isInArray(vocs,getPlayerVocation(cid)) then
        doPlayerSendTextMessage(cid, 4, 'You already are upgraded vocation')
        return false
    else
        local vucs = {1,2,3,4}
        if isInArray(vucs,getPlayerVocation(cid)) then
            doPlayerSendTextMessage(cid, 4, 'You need first normal promotion in order to use this')
        else
            local allVocs = {1,2,3,4,5,6,7,8}
            if not isInArray(allVocs,getPlayerVocation(cid)) then
                doPlayerSendTextMessage(cid, 4, 'You have an invalid vocation')
            else
               doPlayerSetVocation(cid, getPlayerVocation(cid)+4)
               doRemoveItem(item.uid,1)
            end
        end
    end
    return true
end

Vlw Jami, script atualizado!